Skip to content

Updating base dialog to handle backdropClick

Frank Nankivell requested to merge base-dialog-update into master

In order to to handle cases where we do not want to close the modal for backdropClick - the props here need updating to handle two paramaters

This then means we can pass something like the following to this component

   onClose={(event, reason) => {
        if(reason !== 'backdropClick' && reason !== 'escapeKeyDown') {
            // Set 'open' to false, however you would do that with your particular code.
            setOpen(false);
        }

Not - i've not updated this before so not exactly sure of the workflow

But assume we do the following:

  • update
  • release new tag
  • set new tag in mvp
  • test that it works

Merge request reports